Re: [PATCH v5 3/3] of: Respect #{iommu,msi}-cells in maps

From: Vijayanand Jitta

Date: Tue Jan 20 2026 - 00:09:13 EST




On 1/19/2026 2:34 AM, kernel test robot wrote:
> Hi Vijayanand,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on robh/for-next]
> [also build test ERROR on pci/next pci/for-linus xen-tip/linux-next linus/master v6.19-rc5 next-20260116]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Vijayanand-Jitta/of-Add-convenience-wrappers-for-of_map_id/20260119-021706
> base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
> patch link: https://lore.kernel.org/r/20260118181125.1436036-4-vijayanand.jitta%40oss.qualcomm.com
> patch subject: [PATCH v5 3/3] of: Respect #{iommu,msi}-cells in maps
> config: i386-allnoconfig (https://download.01.org/0day-ci/archive/20260119/202601190432.C5Aya7rJ-lkp@xxxxxxxxx/config)
> compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260119/202601190432.C5Aya7rJ-lkp@xxxxxxxxx/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202601190432.C5Aya7rJ-lkp@xxxxxxxxx/
>
> All error/warnings (new ones prefixed by >>):
>
> In file included from include/linux/cpufreq.h:17,
> from kernel/sched/sched.h:31,
> from kernel/sched/rq-offsets.c:5:
>>> include/linux/of.h:937:1: error: expected identifier or '(' before '{' token
> 937 | {
> | ^
>>> include/linux/of.h:934:19: warning: 'of_map_id' used but never defined
> 934 | static inline int of_map_id(const struct device_node *np, u32 id, const char *map_name,
> | ^~~~~~~~~
> make[3]: *** [scripts/Makefile.build:182: kernel/sched/rq-offsets.s] Error 1
> make[3]: Target 'prepare' not remade because of errors.
> make[2]: *** [Makefile:1314: prepare0] Error 2
> make[2]: Target 'prepare' not remade because of errors.
> make[1]: *** [Makefile:248: __sub-make] Error 2
> make[1]: Target 'prepare' not remade because of errors.
> make: *** [Makefile:248: __sub-make] Error 2
> make: Target 'prepare' not remade because of errors.
>
>
> vim +937 include/linux/of.h
>
> 0384e8c6c6fa49 Pantelis Antoniou 2015-01-21 933
> eb8f695e71ec36 Robin Murphy 2026-01-18 @934 static inline int of_map_id(const struct device_node *np, u32 id, const char *map_name,
> eb8f695e71ec36 Robin Murphy 2026-01-18 935 const char *cells_name, const char *map_mask_name,
> eb8f695e71ec36 Robin Murphy 2026-01-18 936 struct of_map_id_arg *arg);
> 2a6db719c92dbf Nipun Gupta 2018-09-10 @937 {
> 2a6db719c92dbf Nipun Gupta 2018-09-10 938 return -EINVAL;
> 2a6db719c92dbf Nipun Gupta 2018-09-10 939 }
> 2a6db719c92dbf Nipun Gupta 2018-09-10 940
>

Acknowledged. Apologies for the oversight, I will fix this and submit v6 shortly.

Thanks,
Vijay