Re: [PATCH v14 10/34] PCI/AER: Update is_internal_error() to be non-static is_aer_internal_error()
From: dan.j.williams
Date: Tue Jan 20 2026 - 11:53:58 EST
Bowman, Terry wrote:
> On 1/19/2026 8:20 PM, dan.j.williams@xxxxxxxxx wrote:
> > Terry Bowman wrote:
> >> The AER driver includes significant logic for handling CXL protocol errors.
> >> The AER driver will be updated in the future to separate the AER and CXL
> >> logic.
> >>
> >> Rename the is_internal_error() function to is_aer_internal_error() as it
> >> gives a more precise indication of the purpose. Make is_aer_internal_error()
> >> non-static to allow for other PCI drivers to access.
> >
> > Not even sure this rename is needed given that it is private to
> > drivers/pci/pcie/ and the sharing is only for cxl_{rch,vh}.c, not for
> > "other PCI drivers". Consistent with the idea that internal errors are
> > not going to become a first-class citizen let us keep this a CXL-only
> > consideration.
> >
> > I'll update the changelog to drop the "other PCI drivers" comment.
>
> The name choice was addressed by Bjorn here:
>
> https://lore.kernel.org/linux-cxl/20251208180624.GA3300935@bhelgaas/
Thanks, yes, I only folded in the following changes to the changelog:
10: 417535d35e9f ! 11: 098f14e1d884 PCI/AER: Update is_internal_error() to be non-static is_aer_internal_error()
@@ Commit message
logic.
Rename the is_internal_error() function to is_aer_internal_error() as it
- gives a more precise indication of the purpose. Make is_aer_internal_error()
- non-static to allow for other PCI drivers to access.
+ gives a more precise indication of the purpose. Make
+ is_aer_internal_error() non-static to allow for the 2 different CXL
+ topology error model implementations (RCH and VH) to share this helper.
Signed-off-by: Terry Bowman <terry.bowman@xxxxxxx>
-
- ---
-
- Changes in v13->v14:
- - New patch
+ Link: https://patch.msgid.link/20260114182055.46029-11-terry.bowman@xxxxxxx
+ Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>