Re: [PATCH v9 17/22] KVM: x86: Advertise support for FRED

From: Xin Li

Date: Tue Jan 20 2026 - 04:10:17 EST




> On Jan 20, 2026, at 12:07 AM, Chao Gao <chao.gao@xxxxxxxxx> wrote:
>
> On Mon, Jan 19, 2026 at 10:56:29PM -0800, Xin Li wrote:
>>
>>
>>> On Nov 11, 2025, at 11:30 PM, Chao Gao <chao.gao@xxxxxxxxx> wrote:
>>>
>>> I'm not sure if AMD CPUs support FRED, but just in case, we can clear FRED
>>> i.e., kvm_cpu_cap_clear(X86_FEATURE_FRED) in svm_set_cpu_caps().
>>
>> AMD will support FRED, with ISA level compatibility:
>>
>> https://www.amd.com/en/blogs/2025/amd-and-intel-celebrate-first-anniversary-of-x86-ecosys.html
>>
>> Thus we don’t need to clear the bit.
>
> In this case, we need to clear FRED for AMD.
>
> The concern is that before AMD's FRED KVM support is implemented, FRED will be
> exposed to userspace on AMD FRED-capable hardware. This may cause issues.

Hmm, I think it’s Qemu does that.

We have 2 filters, one in Qemu and one in KVM, only both are set a feature is enabled.

What I have missed?