Re: [PATCH 1/6] x86/cpu: Break Vendor/Family/Model macros into separate header

[Andy Shevchenko]

On Tue, Jan 20, 2026 at 07:03:31AM -0800, Dave Hansen wrote:
> On 1/20/26 00:24, Andy Shevchenko wrote:
> >> +#define	VFM_MODEL_MASK	GENMASK(VFM_FAMILY_BIT - 1, VFM_MODEL_BIT)
> >> +#define	VFM_FAMILY_MASK	GENMASK(VFM_VENDOR_BIT - 1, VFM_FAMILY_BIT)
> >> +#define	VFM_VENDOR_MASK	GENMASK(VFM_RSVD_BIT - 1, VFM_VENDOR_BIT)
> > There are tabs after #define, is it on purpose?
> > (yes, I know this is simple move, but if not deliberate, we can tweak
> >  the tabs/spaces while at it)
> 
> Yes, you can, but I chose not to here. Is there any compelling reason to
> tweak it?

The usual style to use spaces there. Using tabs makes it mixed and
inconsistent. So the expectation of a define is

#define<single space>$FOO<TAB(s)>$VALUE

-- 
With Best Regards,
Andy Shevchenko