Re: [PATCH] mm/pagewalk: use min() to simplify the code

[Lorenzo Stoakes]

On Tue, Jan 20, 2026 at 05:49:32PM +0800, zenghongling wrote:
> Use the min() macro to simplify the function and improve
> its readability.
>
> Signed-off-by: zenghongling <zenghongling@xxxxxxxxxx>

LGTM, other than nit below (Andrew, maybe you can insert a newline there?) so:

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>

> ---
>  mm/pagewalk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/pagewalk.c b/mm/pagewalk.c
> index 9f91cf85a5be..82db421b5b34 100644
> --- a/mm/pagewalk.c
> +++ b/mm/pagewalk.c
> @@ -313,7 +313,7 @@ static unsigned long hugetlb_entry_end(struct hstate *h, unsigned long addr,
>  				       unsigned long end)
>  {
>  	unsigned long boundary = (addr & huge_page_mask(h)) + huge_page_size(h);

Nit: Ideally we'd introduce a space between decl and statement below.

> -	return boundary < end ? boundary : end;
> +	return min(boundary, end);
>  }
>
>  static int walk_hugetlb_range(unsigned long addr, unsigned long end,
> --
> 2.25.1
>