Re: [PATCH 1/3] doc: add Device Tree binding for AMS TCS3400 light sensor
From: Krzysztof Kozlowski
Date: Tue Jan 20 2026 - 05:37:24 EST
On Mon, Jan 19, 2026 at 06:19:06PM +0100, Petr Hodina wrote:
> Adds a new YAML binding describing the AMS TCS3400 I2C light sensor,
> including compatible string, registers, interrupts, power supply, and an
> example node.
>
> Signed-off-by: Petr Hodina <petr.hodina@xxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/iio/light/ams,tcs3400.yaml | 54 ++++++++++++++++++++++
> MAINTAINERS | 6 +++
> 2 files changed, 60 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/light/ams,tcs3400.yaml b/Documentation/devicetree/bindings/iio/light/ams,tcs3400.yaml
> new file mode 100644
> index 000000000000..2c5a9295af1a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/ams,tcs3400.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/iio/light/ams,tcs3400.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
Never tested.
> +
> +title: AMS TCS3400 Color Light-to-Digital Converter
> +
> +maintainers:
> + - name: Petr Hodina
> + email: petr.hodina@xxxxxxxxxxxxxx
Don't send us LLM code. Never. Why do I think you sent us LLM microslop?
Because such syntax does not exist. Nowhere.
I finished the review here, everything futher has more trivial issues
which you would fix easily if you took recent binding as starting point.
Best regards,
Krzysztof