Re: [PATCH] drm/rockchip: vop2: Add mode valid callback for crtc

[Daniel Stone]

Hi Andy,

On Fri, 9 Jan 2026 at 00:59, Andy Yan <andyshrk@xxxxxxx> wrote:
> Filter the mode that can't output by the crtc.
>
> [...]
>
> +static enum drm_mode_status vop2_crtc_mode_valid(struct drm_crtc *crtc,
> +                                                const struct drm_display_mode *mode)
> +{
> +       struct vop2_video_port *vp = to_vop2_video_port(crtc);
> +
> +       if (mode->hdisplay > vp->data->max_output.width)
> +               return MODE_BAD_HVALUE;

Why not test height as well?

Cheers,
Daniel