Re: [PATCH v2 1/3] dt-bindings: display: msm: qcm2290-mdss: Fix iommus property

[Krzysztof Kozlowski]

On 20/01/2026 13:16, Sumit Garg wrote:
> 
>>
>>>
>>> There has been ongoing disscusion related to how stream ID associated
>>> with different translation context can be represented in DT here [1].
>>> With that only the secure bank stream IDs can be properly represented.
>>>
>>> Here I just followed the approach taken by Adreno GPU bindings for the
>>> iommus property [2].
>>>
>>> [2] Documentation/devicetree/bindings/display/msm/gpu.yaml +82
>>
>> Such justifications are pointless. What about commit msg which explains
>> why this was added? What about entire public discussion happening with
>> this patch? What about all previous revisions of that patch and
>> discussions leading to this piece of code? So you just found few lines
>> of code, ignored entire background and any other arguments, and copied
>> it here.
> 
> Looks like you are mixing other patch-set with this one.

How different? You found some old code and use it as argument that you
can do the same:

"Here I just followed the approach taken by Adreno GPU bindings for the"

so how I am mixing patchsets in my response above?


> 
>>
>> That's the approach - I found a piece of some buggy code, so I can do
>> the same.
>>
>> Again, we discussed it 2-3 months ago for the same patch and I gave
>> exactly same reason why this patch is incomplete.
> 
> Sorry you are just mixing different discussions here. I am trying to fix

How am I mixing? Exactly same approach was posted for other SoC. I gave
same comments. Same comments apply here.

> the SMMU stream IDs for Agatti SoC which listed secure bank stream IDs
> incorrectly.

You explain what you did, but you did not explain why or how I mixed
anything.

> 
> And this is the first version of this patch only for DT bindings fix for
> Agatti, there are no prior discussions I had on this aspect upstream.

I did not say you had discussions before. I said exactly same problems
were being solved and I give here and there exactly the same feedback.

Best regards,
Krzysztof