Re: [PATCH v2] fs/hfs: fix s_fs_info leak on setup_bdev_super() failure

[Mehdi Ben Hadj Khelifa]

On 1/19/26 9:55 PM, Viacheslav Dubeyko wrote:
> On Mon, 2026-01-19 at 22:34 +0100, Mehdi Ben Hadj Khelifa wrote:
> > On 1/19/26 7:27 PM, Viacheslav Dubeyko wrote:
> > >
>
> <skipped>
>
> > >
> > I have ran xfstests on both my desktop and laptop on the for-next branch
> > for the repository that you have mentionned and I didn't have any crash
> > or issue. Here is the test results(identical for both desktop and laptop):
> > FSTYP         -- hfsplus
> > PLATFORM      -- Linux/x86_64 bhk 6.19.0-rc1-00008-ged8889ca21b6 #1 SMP
> > PREEMPT_DYNAMIC Mon Jan 19 20:53:58 CET 2026
> > MKFS_OPTIONS  -- /dev/loop1
> > MOUNT_OPTIONS -- /dev/loop1 /mnt/scratch
> >
> > generic/001  2s ...  2s
> > generic/002  1s ...  1s
> > <skip>
> > Failed 51 of 772 tests
>
> The 51 failed xfstests is expected situation. However, if you apply [1,2] on
> xfstests code base, then you could have around 31 failed xfeststs for HFS+.
I have applied both patches and got the expected results on my desktop 
and laptop:
Failed 31 of 772 tests
I can confirm that indeed those patches fix 20 of the previously failed 
tests.
> Thanks,
> Slava.
Best Regards,
Mehdi Ben hadj Khelifa
> > Many tests were skipped of course. If you want full output I can send
> > you that.But for now the issue seem to be resolved (for hfsplus at least
> > I'm not sure about hfs since I still can't test it on my system).
> > Thanks for your efforts slava.
>
> [1]
> https://lore.kernel.org/linux-fsdevel/20260118180519.xdddwoke2tey6ogt@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
> [2]
> https://lore.kernel.org/linux-fsdevel/20251231224937.uu67l76cytcd36ns@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/