Re: [PATCH v2] staging: rtl8723bs: fix unchecked return value of skb_copy_bits
From: Andy Shevchenko
Date: Tue Jan 20 2026 - 09:03:42 EST
On Tue, Jan 20, 2026 at 04:59:29PM +0300, Dan Carpenter wrote:
> On Tue, Jan 20, 2026 at 10:22:41PM +0900, Minu Jin wrote:
...
> > + signed int ret;
>
> Don't put a blank line in the middle of the declaration block. Just do
> "int ret;". Everyone knows "int" is signed. Don't follow the local
> style when the local style is wrong. Also only use s32 when it's part
> of a networking or hardware spec. Just use int. Do people imagine that
> we'll change int to be unsigned?
Not in a far past we changed char to be unsigned :-)
*Yes I know that it's a bit different case.
--
With Best Regards,
Andy Shevchenko