Re: [PATCH 4/6] x86/cpu: Add platform ID to CPU info structure

[Dave Hansen]

On 1/20/26 00:27, Andy Shevchenko wrote:
...
>> Note: This should not grow the size of 'struct cpuinfo_x86' in
>> practice since the u8 fits next to another u8 in the structure.
> 
> Have you run `pahole` to confirm?

I have not. If you'd like to contribute to the series by compiling this
and running pahole on it, I'd very much appreciate it!

> ...
> 
>>  	c->x86_cache_size = 0;
>>  	c->x86_vendor = X86_VENDOR_UNKNOWN;
>> -	c->x86_model = c->x86_stepping = 0;	/* So far unknown... */
> 
> Shan't we preserve the comment?
> 
> 	/* So far model, stepping, and platform_id are unknown... */

... and cache size and vendor and everything else. It's not a super
useful comment.