Re: [PATCH 4/6] x86/cpu: Add platform ID to CPU info structure

[Dave Hansen]

On 1/19/26 19:14, Chao Gao wrote:
>> 	__u8			x86_stepping;
>> +	__u8			x86_platform_id; /* Intel-only. 3 bits */
> Tail comments are not preferred. I've seen tglx complain about them a few times.

Yeah, you're right. It doesn't fit well with the rest of the structure.
I'll fix it.

> Also, "3 bits" is misleading since x86_platform_id actually stores a bit mask.

Remember, there are two structures in play here. From the cover letter:

> Treat the platform ID as a peer of model/family/stepping. Store it
> in 'struct cpuinfo_x86', enable matching on it with with 'struct
> x86_cpu_id', and flesh out the 'old_microcode' list with it.

This hunk is patching 'cpuinfo_x86' which stores the 3 bits explicitly.

I think you're thinking of the mask in 'x86_cpu_id' which is used for
_matching_ this field in patch 5.

Could you double check that you're asking about the right structure,
please? I've certainly gotten the two structures mixed up before.