Re: [PATCH v12 08/10] pkcs7, x509: Add RSASSA-PSS support

[David Howells]

Ignat Korchagin <ignat@xxxxxxxxxxxxxx> wrote:

> > +       struct rsassa_parameters *rsassa __free(kfree) =
> 
> Did you mean to use the newly added rsassa_params_free() here?

Err, yes, I should have done.

> > +DEFINE_FREE(rsassa_params_free,  struct rsassa_parameters*, rsassa_params_free(_T))
> 
> So you use plain kfree() in one instance and this custom free definition in
> another.  We should probably pick one.

Yeah, both should have used the custom one.

> What is the idea behind this custom rsassa_params_free(), if it just calls
> into kfree()?

In case in future something freeable is added to it, it seems like a good idea
to have a destructor[*].  Other mask functions are theoretically possible, for
example.

[*] (Since we seem to be reinventing C++ ;-)

David