Re: [PATCH v3 5/8] media: qcom: camss: csiphy-3ph: Add Gen2 v1.1 MIPI CSI-2 CPHY init

From: Bryan O'Donoghue

Date: Sun Jan 18 2026 - 05:27:10 EST


On 18/01/2026 09:51, David Heidelberg wrote:

If checkpatch.pl doesn't complain about it, I think it probably should.

Please standardise the location of the comment and have one for the CPHY and one for the DPHY configs.

Then I can rather replace the else with elseif (== DPHY) and make the comment irrelevant. What is your recommendation?

David>

I think the code is pretty self-documenting without a comment.

---
bod