Re: [PATCH v5 08/14] ntfs: update attrib operations

[Namjae Jeon]

On Fri, Jan 16, 2026 at 6:18 PM Christoph Hellwig <hch@xxxxxx> wrote:
>
> > +/* log base 2 of the number of entries in the hash table for match-finding.  */
> > +#define HASH_SHIFT           14
> > +
> > +/* Constant for the multiplicative hash function.  */
> > +#define HASH_MULTIPLIER              0x1E35A7BD
>
> The hashing here doesn't seem very efficient.  Is that part of
> the on-disk format in some way?  If so it would be great to
> document that.  If not it might be worth to look into better
> hashing helpers from the library functions in the kernel (not needed
> for inclusion, but probably worth it).
I will check it and add the comment if needed.
>
> > +struct COMPRESS_CONTEXT {
>
> Other parts of the code got rid of the Window-Style all upper
> case names, why add a new one here?
Ah, Okay, I will change it.
Thanks!
>