Re: [net-next] net: phy: intel-xway: workaround stale LEDs before link-up
From: Jakub Kicinski
Date: Sat Jan 17 2026 - 21:31:47 EST
On Sat, 17 Jan 2026 18:29:07 -0800 Jakub Kicinski wrote:
> > @@ -286,8 +287,33 @@ static int xway_gphy_config_init(struct phy_device *phydev)
> > return err;
> >
> > /* Use default LED configuration if 'leds' node isn't defined */
> > - if (!of_get_child_by_name(np, "leds"))
> > + if (!of_get_child_by_name(np, "leds")) {
> > xway_gphy_init_leds(phydev);
> > + } else {
>
> Does this leak the device_node reference returned by of_get_child_by_name()?
Of course this is a pre-existing issue but could you fix it first
in net then proceed with this submission? Otherwise we'll have a
conflict.