Re: [PATCH v6 1/3] sched/fair: Co-locate cfs_rq and sched_entity

From: Zecheng Li

Date: Sat Jan 17 2026 - 20:49:31 EST


Hi Josh,

Thanks for the review.

On Thu, Jan 15, 2026 at 7:48 PM Josh Don <joshdon@xxxxxxxxxx> wrote:
>
> Now that we have a general purpose container struct (cfs_rq_with_se),
> I wonder if it makes more sense to get rid of sched_entity_stats and
> directly embed se and stats in cfs_rq_with_se.

Yes, that makes sense. I'll remove sched_entity_stats and embed
cfs_rq, sched_entity and stats in the container struct for v7.

> > +
> > +struct cfs_rq_with_se {
> > + struct cfs_rq cfs_rq;
> > + struct sched_entity_stats ses;
> > +};
> > +#endif
>
> nit: The struct name feels a bit awkward, perhaps something like tg_cfs_state?
>

Sure. I'm thinking cfs_tg_state to keep consistent with the cfs_
prefix used elsewhere in the fair scheduler.