Re: [PATCH v3 03/12] rust: macros: convert `#[vtable]` macro to use `syn`
From: Benno Lossin
Date: Sat Jan 17 2026 - 14:25:55 EST
On Mon Jan 12, 2026 at 6:07 PM CET, Gary Guo wrote:
> From: Gary Guo <gary@xxxxxxxxxxx>
>
> `#[vtable]` is converted to use syn. This is more robust than the
> previous heuristic-based searching of defined methods and functions.
>
> When doing so, the trait and impl are split into two code paths as the
> types are distinct when parsed by `syn`.
>
> Reviewed-by: Tamir Duberstein <tamird@xxxxxxxxx>
> Signed-off-by: Gary Guo <gary@xxxxxxxxxxx>
Reviewed-by: Benno Lossin <lossin@xxxxxxxxxx>
Cheers,
Benno
> ---
> rust/macros/lib.rs | 9 ++-
> rust/macros/vtable.rs | 169 +++++++++++++++++++++++-------------------
> 2 files changed, 98 insertions(+), 80 deletions(-)