Re: [PATCH v4 0/9] Add support for AD4062 device family

From: Sasha Levin

Date: Sat Jan 17 2026 - 10:12:35 EST


Hi Jonathan, Jorge,

Heads up: the AD4062 driver uses the deprecated I3C API which was
removed in commit 9904232ae30bc ("i3c: drop i3c_priv_xfer and
i3c_device_do_priv_xfers()"). This causes build failures when
merged with trees containing that commit:

drivers/iio/adc/ad4062.c:471:24: error: variable 'xfer_trigger' has initializer but incomplete type
471 | struct i3c_priv_xfer xfer_trigger = {
| ^~~~~~~~~~~~~
drivers/iio/adc/ad4062.c:472:26: error: 'struct i3c_priv_xfer' has no member named 'data'
...

The fix is straightforward - migrate to the new API:

- struct i3c_priv_xfer -> struct i3c_xfer
- i3c_device_do_priv_xfers(dev, xfers, n) -> i3c_device_do_xfers(dev, xfers, n, I3C_SDR)

The struct fields are identical (i3c_priv_xfer was just a #define
alias), and I3C_SDR is what the old wrapper used internally.

--
Thanks,
Sasha