Re: [PATCH net-next] net: ethernet: litex: use devm_register_netdev() to register netdev

From: Inochi Amaoto

Date: Fri Jan 16 2026 - 19:30:24 EST


On Fri, Jan 16, 2026 at 06:20:05PM +0100, Andrew Lunn wrote:
> On Fri, Jan 16, 2026 at 08:31:50AM +0800, Inochi Amaoto wrote:
> > Use devm_register_netdev to avoid unnecessary remove() callback in
> > platform_driver structure.
>
> > - netdev = devm_alloc_etherdev(&pdev->dev, sizeof(*priv));
> > + netdev = devm_alloc_etherdev(dev, sizeof(*priv));
> > if (!netdev)
> > return -ENOMEM;
>
> The commit message does not fit the actual change.
>
> You probably want to split this into multiple patches. Ideally you
> want lots of small patches with good commit messages which are
> obviously correct.
>

In fact, I just change them by the way and it is not a obvious change,
OK, I will split it and send a new version.

Regards,
Inochi