Re: [PATCH 2/8] soc: tenstorrent: Add header with Atlantis syscon register offsets
From: Anirudh Srinivasan
Date: Fri Jan 16 2026 - 16:34:22 EST
Hi Krzysztof,
On Fri, Jan 16, 2026 at 3:06 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
>
> There is no user of this. Split your work in logical patches. Adding
> unused header is not a meaningful logical split because it is unused.
Understood
>
> Completely unreadable: missing any sort of reasonable indent between
> values.
I had formatted these with clang-format, but it doesn't look good. I
can make it a bit better.
>
> Why do you need to doicument register values and provide them to all
> kernel drivers?
(Including the subsequent commits), these registers documented in this
file are shared across the clock and reset controller, so they're
added here (soc/tenstorrent).