Re: [PATCH] scripts: generate_rust_analyzer.py: reduce cfg plumbing

[Tamir Duberstein]

On Fri, Jan 16, 2026 at 2:42 PM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Fri, Jan 16, 2026 at 5:11 PM Tamir Duberstein <tamird@xxxxxxxxxx> wrote:
> >
> > Plumb `pin-init{,-internal}` cfgs from Makefile to rust-analyzer and
> > automatically interpret `--cfg <crate>=<cfg>` as applying to <crate>.
>
> So I guess the goal is to simplify things and avoid duplicate
> information, which is good, but in general commits should explain why
> the change is done (i.e. not just what is done), even if it may seem
> obvious (for patches you receive, then you should ask the same to
> submitters! :).
>
> In addition, for the `rust/Makefile` ones, I try to mark those as
> "rust: kbuild:" where possible/reasonable -- for instance, this could
> be split into two patches. The first one would be the "rust: kbuild:"
> factoring out the flags into the new variables and the second would
> then be the rust-analyzer one that only would need the extra two
> arguments in `rust/Makefile`.

Sounds good, will send as two patches in v2.

> The changes themselves seem fine.
>
> Cc'ing Kbuild as well (there is no major change here, but still, I do
> it out of habit).
>
> Thanks!
>
> Cheers,
> Miguel

Thanks!