Re: [PATCH v4 2/4] scripts/kernel-doc: avoid error_count overflows
From: Jonathan Corbet
Date: Fri Jan 16 2026 - 13:17:29 EST
Randy Dunlap <rdunlap@xxxxxxxxxxxxx> writes:
> Mauro,
> The line formatting is weird on one line below
> (looks like 2 text lines are joined).
>
> On 1/14/26 4:57 AM, Mauro Carvalho Chehab wrote:
>> The glibc library limits the return code to 8 bits. We need to
>> stick to this limit when using sys.exit(error_count).
>>
>> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
>> Cc: stable@xxxxxxxxxxxxxxx
>> ---
>> scripts/kernel-doc.py | 25 ++++++++++++++++++-------
>> 1 file changed, 18 insertions(+), 7 deletions(-)
>>
>> diff --git a/scripts/kernel-doc.py b/scripts/kernel-doc.py
>> index 7a1eaf986bcd..3992ca49d593 100755
>> --- a/scripts/kernel-doc.py
>> +++ b/scripts/kernel-doc.py
>> @@ -116,6 +116,8 @@ SRC_DIR = os.path.dirname(os.path.realpath(__file__))
>>
>> sys.path.insert(0, os.path.join(SRC_DIR, LIB_DIR))
>>
>> +WERROR_RETURN_CODE = 3
>> +
>> DESC = """
>> Read C language source or header FILEs, extract embedded documentation comments,
>> and print formatted documentation to standard output.
>> @@ -176,7 +178,20 @@ class MsgFormatter(logging.Formatter):
>> return logging.Formatter.format(self, record)
>>
>> def main():
>> - """Main program"""
>> + """
>> + Main program
>> + By default, the return value is:
>> +
>> + - 0: success or Python version is not compatible with kernel-doc. If -Werror is not used, it will also
>
> Here ^^^^^
>
Mauro, can you get me a clean copy? It seems like we're more than ready
to apply this set otherwise...
Thanks,
jon