[PATCH v3 02/27] gpib: agilent_82357a: Fix the *allocate_private retval check

From: Dominik Karol Piątkowski

Date: Fri Jan 16 2026 - 12:47:42 EST


Change

if (retval < 0)
return retval;

into

if (retval)
return retval;

as it is more fitting in this case.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@xxxxxxxxxxxxxx>
---

v3:
- Change `(retval < 0)` to `(retval)`

drivers/gpib/agilent_82357a/agilent_82357a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpib/agilent_82357a/agilent_82357a.c b/drivers/gpib/agilent_82357a/agilent_82357a.c
index 77c8e549b208..26d2830c3fa3 100644
--- a/drivers/gpib/agilent_82357a/agilent_82357a.c
+++ b/drivers/gpib/agilent_82357a/agilent_82357a.c
@@ -1316,7 +1316,7 @@ static int agilent_82357a_attach(struct gpib_board *board, const struct gpib_boa
return -ERESTARTSYS;

retval = agilent_82357a_allocate_private(board);
- if (retval < 0) {
+ if (retval) {
mutex_unlock(&agilent_82357a_hotplug_lock);
return retval;
}
--
2.43.0