Re: [PATCH] usb: dwc3: google: Remove redundant dev_err()

[Thinh Nguyen]

On Thu, Jan 15, 2026, Chen Ni wrote:
> The platform_get_irq_byname() function already prints an error message
> internally upon failure using dev_err_probe(). Therefore, the explicit
> dev_err() is redundant and results in duplicate error logs.
> 
> Remove the redundant dev_err() call to clean up the error path.
> 
> Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>
> ---
>  drivers/usb/dwc3/dwc3-google.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-google.c b/drivers/usb/dwc3/dwc3-google.c
> index a19857bd6b13..2105c72af753 100644
> --- a/drivers/usb/dwc3/dwc3-google.c
> +++ b/drivers/usb/dwc3/dwc3-google.c
> @@ -228,10 +228,8 @@ static int dwc3_google_request_irq(struct dwc3_google *google, struct platform_d
>  	int irq;
>  
>  	irq = platform_get_irq_byname(pdev, irq_name);
> -	if (irq < 0) {
> -		dev_err(google->dev, "invalid irq name %s\n", irq_name);
> +	if (irq < 0)
>  		return irq;
> -	}
>  
>  	irq_set_status_flags(irq, IRQ_NOAUTOEN);
>  	ret = devm_request_threaded_irq(google->dev, irq, NULL,
> -- 
> 2.25.1
> 

Acked-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>

BR,
Thinh