Re: [v4, net-next 2/7] bng_en: Add RX support

[Bhargava Chenna Marreddy]

On Tue, Jan 13, 2026 at 1:14 AM Bhargava Chenna Marreddy
<bhargava.marreddy@xxxxxxxxxxxx> wrote:
>
> On Thu, Jan 8, 2026 at 3:15 PM Paolo Abeni <pabeni@xxxxxxxxxx> wrote:
> >
> > On 1/5/26 8:21 AM, Bhargava Marreddy wrote:
> > > +
> > > +     dma_sync_single_for_device(bd->dev, mapping, bn->rx_copybreak,
> > > +                                bn->rx_dir);
> >
> > Why is the above needed?
>
> Since the buffer is being reused, the for_device sync hands ownership
> back to the hardware.
> This ensures the memory is ready for the next DMA transfer and
> maintains consistency on non-coherent architectures.
> Any concerns with this?

Thanks, Paolo. You're correct. I took another look and realized the
for_device sync
is redundant here since the CPU only reads the data and hasn't written
to the buffer.
I'll remove this in the next revision.

Thanks,
Bhargava Marreddy

>
> >
> > > +
> > > +     skb_put(skb, len);
> > > +
> > > +     return skb;
> > > +}
> > > +

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature