Re: [PATCH 6/7] clk: st: clkgen-pll: Remove redundant kfree() in clkgen_c32_pll_setup()
From: Brian Masney
Date: Fri Jan 16 2026 - 10:45:38 EST
On Fri, Jan 16, 2026 at 07:38:46PM +0800, Haoxiang Li wrote:
> In clkgen_c32_pll_setup(), pll_name is actually pll_clk -> core->name.
> This variable will be released in clk_unregister() -> __clk_release()
> if some error occurs. Thus kfree(pll_name) will cause a double free.
> Remove this redundant kfree().
>
> Signed-off-by: Haoxiang Li <lihaoxiang@xxxxxxxxxxxxxxxx>
A fixes tag is definitely appropriate here.
Fixes: b9b8e614b580 ("clk: st: Support for PLLs inside ClockGenA(s)")
Reviewed-by: Brian Masney <bmasney@xxxxxxxxxx>