Re: [PATCH v3 2/4] staging: rtl8723bs: simplify boolean expressions

[Khushal Chitturi]

On 1/16/26 6:41 PM, Greg KH wrote:
> On Fri, Jan 16, 2026 at 11:00:50AM +0530, Khushal Chitturi wrote:
> > Simplify boolean expressions in rtw_xmit.c to
> > comply with the kernel coding style
>
> Please use the full 72 characters on a line.
>
> > Signed-off-by: Khushal Chitturi <khushalchitturi@xxxxxxxxx>
> >
> > ---
> > Changelog:
> > v2 -> v3: Resubmitted as a versioned series to avoid threading confusion.
> > v1 -> v2: Corrected commit messages.
> >
> >   drivers/staging/rtl8723bs/core/rtw_xmit.c | 38 ++++++++++++-----------
> >   1 file changed, 20 insertions(+), 18 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> > index bbc42db1c828..97e38ef62ac4 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> > @@ -384,7 +384,8 @@ static void update_attrib_vcs_info(struct adapter *padapter, struct xmit_frame *
> >   	} else {
> >   		while (true) {
> >   			/* IOT action */
> > -			if ((pmlmeinfo->assoc_AP_vendor == HT_IOT_PEER_ATHEROS) && (pattrib->ampdu_en == true) &&
> > +			if ((pmlmeinfo->assoc_AP_vendor == HT_IOT_PEER_ATHEROS) &&
> > +			    (pattrib->ampdu_en) &&
>
> You moved this to the next line in the right place, but here:
>
> > @@ -903,8 +905,8 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattr
> >   
> >   			if (pattrib->qos_en)
> >   				qos_option = true;
> > -		} else if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true) ||
> > -		(check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true)) {
> > +		} else if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) ||
> > +		(check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) {
>
> You did not?  How come?

You're right, I missed the alignment in that second block.
I will fix it and send a v4.

--
Regards,
Khushal