Re: [tip: perf/core] x86/uprobes: Fix XOL allocation failure for 32-bit tasks

[Oleg Nesterov]

On 01/15, tip-bot2 for Oleg Nesterov wrote:
>
> The following commit has been merged into the perf/core branch of tip:

Damn!

thanks Peter, but...

> --- a/arch/x86/kernel/uprobes.c
> +++ b/arch/x86/kernel/uprobes.c
> @@ -1823,3 +1823,27 @@ bool is_uprobe_at_func_entry(struct pt_regs *regs)
>
>  	return false;
>  }
> +
> +#ifdef CONFIG_IA32_EMULATION
> +unsigned long __weak arch_uprobe_get_xol_area(void)

Oh, but x86 version should not be __weak. Copy-and-paste error, sorry :/

What do you want me to do now,

	- send V2 ?

	- send another s/__weak// patch on top of this hack?

	- or perhaps you can fix this yourself?

Oleg.