Re: [PATCH mm-unstable] mm: Fix uffd-wp bit loss when batching file folio unmapping

From: Lorenzo Stoakes

Date: Fri Jan 16 2026 - 04:49:20 EST


On Fri, Jan 16, 2026 at 03:10:23PM +0530, Dev Jain wrote:
>
> On 16/01/26 2:09 pm, Lorenzo Stoakes wrote:
> I saw that the last comment on that series was more than a week back, so best
> thought to just do a folded fix on top of it - and I had formed the impression
> (from the conversations on list) that akpm prefers fixes over respins : )
>
> If a respin is preferred here then I am fine by that.
>

Generally we prefer fix-patches, sent in reply to the patch being altered and
sent by the series author.

Sending a patch with a Fixes: tag is never the correct way to fixup a patch
unless they're upstream or unchangeably-bound-for-upstream with a commit hash
that will be the same in Linus's tree.

You can by all means suggest a patch to an author by replying to the broken
patch, but then it's up to them whether to take it. Also then the courteous way
is to raise the issue in that reply and say something like 'it seems that the
below fixes the issue, can you check it?' or something like this.

But the correct course is to the respond to the series in all cases like this.

Thanks, Lorenzo