RE: [PATCH v3 4/4] mux: gpio-mux: add adi,adg2404 support

[Miclaus, Antoniu]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Friday, January 16, 2026 10:33 AM
> To: Miclaus, Antoniu <Antoniu.Miclaus@xxxxxxxxxx>
> Cc: Peter Rosin <peda@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof
> Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>;
> Srinivas Kandagatla <srini@xxxxxxxxxx>; Johan Hovold
> <johan+linaro@xxxxxxxxxx>; Bartosz Golaszewski
> <bartosz.golaszewski@xxxxxxxxxx>; Linus Walleij <linus.walleij@xxxxxxxxxx>;
> David Lechner <dlechner@xxxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 4/4] mux: gpio-mux: add adi,adg2404 support
> 
> [External]
> 
> On Thu, Jan 15, 2026 at 02:18:22PM +0200, Antoniu Miclaus wrote:
> > Add adi,adg2404 to the compatible list. The ADG2404 is a 4:1 analog
> > multiplexer that benefits from the enable GPIO support to prevent
> > glitches during channel transitions.
> >
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
> > ---
> > changes in v3:
> >  * integrate with gpio-mux driver instead of standalone adg2404 driver
> > ---
> >  drivers/mux/gpio.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c
> > index 93487483e81f..bd8f0c617dd6 100644
> > --- a/drivers/mux/gpio.c
> > +++ b/drivers/mux/gpio.c
> > @@ -59,6 +59,7 @@ static const struct mux_control_ops mux_gpio_ops = {
> >
> >  static const struct of_device_id mux_gpio_dt_ids[] = {
> >  	{ .compatible = "gpio-mux", },
> > +	{ .compatible = "adi,adg2404", },
> 
> Why do you need the compatible? I do not understand this patchset. You
> are saying you integrate it into gpio-mux, but what you did is to
> duplicate the compatible and binding.
> 
> Half of your patches are not necessary, you only needed to add
> enable-gpios to gpio-mux with argument that ADG2404 can use such binding
> (in complete/full/proper way).

I am a bit confused on how can I emphasize to the users explicitly:
"Hey, you can use adg2404 directly with gpio-mux"
The same issue I had with adg1712 series which can be used straight away with gpio-mux.
If there are people/customers looking for adg2404/adg1712 there should be a hint somewhere.
Sorry for my poor knowledge on this, but I need some guidance on what the best approach is to solve it.

Thanks,
> Best regards,
> Krzysztof