Re: [PATCH v4 1/6] media: iris: Add support for multiple clock sources

[Dikshita Agarwal]

On 12/10/2025 6:05 PM, Vikash Garodia wrote:
> vpu4 depends on more than one clock source. Thus far hardware versions
> up to vpu3x have been clocked by a single source.
> This adds support for multiple clocks by,
> - Adding a lookup table
> - Configuring OPP table for video device with different video clocks
> - Setting OPP for multiple clocks during dev_pm_opp_set_opp()
> 
> This patch extends the support for multiple clocks in driver, which
> would be used in subsequent patch for kaanapali, when the platform data
> is prepared.
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> Co-developed-by: Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>
> Signed-off-by: Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>
> Signed-off-by: Vikash Garodia <vikash.garodia@xxxxxxxxxxxxxxxx>
> ---
>  .../media/platform/qcom/iris/iris_platform_common.h  |  1 +
>  .../media/platform/qcom/iris/iris_platform_gen1.c    |  7 +++++++
>  .../media/platform/qcom/iris/iris_platform_gen2.c    |  9 +++++++++
>  .../media/platform/qcom/iris/iris_platform_sc7280.h  |  5 +++++
>  drivers/media/platform/qcom/iris/iris_power.c        |  2 +-
>  drivers/media/platform/qcom/iris/iris_probe.c        | 20 ++++++++------------
>  drivers/media/platform/qcom/iris/iris_resources.c    | 16 ++++++++++++++--
>  drivers/media/platform/qcom/iris/iris_resources.h    |  1 +
>  drivers/media/platform/qcom/iris/iris_vpu_common.c   |  4 ++--
>  9 files changed, 48 insertions(+), 17 deletions(-)
> 

Reviewed-by: Dikshita Agarwal <dikshita.agarwal@xxxxxxxxxxxxxxxx>

Thanks,
Dikshita