Re: [PATCH v8] rust: add new macro for common bitflag operations

From: Andreas Hindborg

Date: Fri Jan 16 2026 - 04:06:40 EST


"Daniel Almeida" <daniel.almeida@xxxxxxxxxxxxx> writes:

>> On 15 Jan 2026, at 16:03, Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>>
>> On Thu, Jan 15, 2026 at 2:45 PM Daniel Almeida
>> <daniel.almeida@xxxxxxxxxxxxx> wrote:
>>>
>>> The flags may be in your uapi or they may otherwise come from C. In that case
>>> you’re stuck with a TryFrom or a manual conversion.
>>>
>>> I think a generated TryFrom shouldn't hurt. Just my 0.02c.
>>
>> I would say let's land this patch as-is (with the doc bit I mentioned)
>> and then we can discuss additions on top independently.
>
> Sure, that is also fine.
>
> Thanks for all the work, Filipe :)

Absolutely, I did not intend to stall this series. Just suggestions for
future work.


Best regards,
Andreas Hindborg