Re: [PATCH v3 4/4] mux: gpio-mux: add adi,adg2404 support

[Krzysztof Kozlowski]

On Thu, Jan 15, 2026 at 02:18:22PM +0200, Antoniu Miclaus wrote:
> Add adi,adg2404 to the compatible list. The ADG2404 is a 4:1 analog
> multiplexer that benefits from the enable GPIO support to prevent
> glitches during channel transitions.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
> ---
> changes in v3:
>  * integrate with gpio-mux driver instead of standalone adg2404 driver
> ---
>  drivers/mux/gpio.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c
> index 93487483e81f..bd8f0c617dd6 100644
> --- a/drivers/mux/gpio.c
> +++ b/drivers/mux/gpio.c
> @@ -59,6 +59,7 @@ static const struct mux_control_ops mux_gpio_ops = {
>  
>  static const struct of_device_id mux_gpio_dt_ids[] = {
>  	{ .compatible = "gpio-mux", },
> +	{ .compatible = "adi,adg2404", },

Why do you need the compatible? I do not understand this patchset. You
are saying you integrate it into gpio-mux, but what you did is to
duplicate the compatible and binding.

Half of your patches are not necessary, you only needed to add
enable-gpios to gpio-mux with argument that ADG2404 can use such binding
(in complete/full/proper way).

Best regards,
Krzysztof