Re: [PATCH 6/6] arm64: dts: qcom: Add Redmi Note 8T

[barnabas . czeman]

On 2026-01-13 10:04, Konrad Dybcio wrote:
> On 1/12/26 9:13 PM, Barnabás Czémán wrote:
> > Redmi Note 8T (willow) is very similar to Redmi Note 8 (ginkgo)
> > the only difference is willow have NFC.
> > Make a common base from ginkgo devicetree for both device.
> >
> > Signed-off-by: Barnabás Czémán <barnabas.czeman@xxxxxxxxxxxxxx>
> > ---
>
> [...]
>
> > diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts 
> > b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
> > index 163ecdc7fd6c..70be19357d11 100644
> > --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
> > +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
> > @@ -1,304 +1,12 @@
> >  // SPDX-License-Identifier: BSD-3-Clause
> >  /*
> > - * Copyright (c) 2025, Gabriel Gonzales <semfault@xxxxxxxxxxx>
> > + * Copyright (c) 2026, Barnabas Czeman
>
> Is there a reason for you to remove Gabriel's copyright from the 5 LoC
> that remain in this file?
The original file was renamed to sm6125-xiaomi-ginkgo-common.dtsi.
I have not removed it, it is a new file with the old file name but
i can add Gabriel's copyright here also, would that be fine?

> Adding your own to an existing file in a commit that mostly moves code
> around is also odd. It would look considerably better if you did so in
> one of the previous commits that fixed things, as those contributions
> are easier to perceive as non-trivial.
>
> Konrad