Re: [PATCH v4 3/4] arm64: dts: qcom: Introduce Glymur base dtsi

[Pankaj Patil]

On 1/14/2026 7:17 PM, Konrad Dybcio wrote:
> On 1/14/26 11:29 AM, Pankaj Patil wrote:
>> On 1/14/2026 9:47 AM, Bjorn Andersson wrote:
>>> On Mon, Jan 12, 2026 at 05:52:36PM +0530, Pankaj Patil wrote:
>>>> Introduce the base device tree support for Glymur – Qualcomm's
>>>> next-generation compute SoC. The new glymur.dtsi describes the core SoC
>>>> components, including:
>>>>
>>>> - CPUs and CPU topology
>>>> - Interrupt controller and TLMM
>>>> - GCC,DISPCC and RPMHCC clock controllers
>>>> - Reserved memory and interconnects
>>>> - APPS and PCIe SMMU and firmware SCM
>>>> - Watchdog, RPMHPD, APPS RSC and SRAM
>>>> - PSCI and PMU nodes
>>>> - QUPv3 serial engines
>>>> - CPU power domains and idle states, plus SCMI/ SRAM pieces for CPU DVFS
>>>> - PDP0 mailbox, IPCC and AOSS
>>>> - Display clock controller
>>>> - SPMI PMIC arbiter with SPMI0/1/2 buses
>>>> - SMP2P nodes
>>>> - TSENS and thermal zones (8 instances, 92 sensors)
>>>>
>>>> Add dtsi files for PMH0101, PMK8850, PMCX0102, SMB2370, PMH0104,
>>>> PMH0110 along with temp-alarm and GPIO nodes needed on Glymur
>>>>
>>>> Enabled PCIe controllers and associated PHY to support boot to
>>>> shell with nvme storage,
>>>> List of PCIe instances enabled:
>>>>
>>>> - PCIe3b
>>>> - PCIe4
>>>> - PCIe5
>>>> - PCIe6
>>>>
>>>
>>> Why didn't you run "make qcom/glymur-crd.dtb CHECK_DTBS=1" before
>>> sending patches to the mailing list?!
>>>
>>> It would taken you 30 seconds to conclude that I can't do anything with
>>> these patches.
>>>
>>> Regards,
>>> Bjorn
>>
>> I've ran the bindings check, dt-bindings specified as dependencies will fix the errors
>> Additionally, I'll drop qup-memory from interconnects for serial and spi in next rev,
>> which cause the bindings errors, this was missed
> 
> The SPI flavor of QUPs is definitely DMA-capable and I don't see how it
> could error out with the current bindings definition
> 
> Konrad

Yes, only serial nodes will error out, will drop for serial/uart nodes