Re: [PATCH 2/2] zram: fixup read_block_state()

[Sergey Senozhatsky]

On (26/01/15 14:07), Andrew Morton wrote:
> On Thu, 15 Jan 2026 12:30:06 +0900 Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> wrote:
> 
> > ac_time is now in seconds, do not use ktime_to_timespec64()
> 
> Please help me out here - which patch introduced the issue which Chris
> found?

This one:
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/zram-use-u32-for-entry-ac_time-tracking.patch

> > Reported-by: Chris Mason <clm@xxxxxxxx>
> 
> The Closes: link would be helpful.

I thought that for fixup patches that are still in your tree we
don't need Closes: tags.  If you prefer to have them, it should
be this email:
http://lore.kernel.org/linux-kernel/20260114124522.1326519-1-clm@xxxxxxxx

[..]
> > -		ts = ktime_to_timespec64(zram->table[index].attr.ac_time);
> >  		copied = snprintf(kbuf + written, count,
> > -			"%12zd %12lld.%06lu %c%c%c%c%c%c\n",
> > -			index, (s64)ts.tv_sec,
> > -			ts.tv_nsec / NSEC_PER_USEC,
> > +			"%12zd %12u.%06lu %c%c%c%c%c%c\n",
> > +			index, zram->table[index].attr.ac_time, 0,
> 
> local `ts' is now unused?

Oh, yes.  Somehow my compiler didn't notice that.