Re:Re: [net-next v7 5/8] net: wwan: add NMEA port support

[Slark Xiao]

At 2026-01-20 20:30:37, "Simon Horman" <horms@xxxxxxxxxx> wrote:
>On Thu, Jan 15, 2026 at 07:46:22PM +0800, Slark Xiao wrote:
>
>...
>
>> diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
>
>...
>
>> +#else
>> +static inline int wwan_port_register_gnss(struct wwan_port *port)
>> +{
>> +	return -EOPNOTSUPP;
>> +}
>> +
>> +static inline void wwan_port_unregister_gnss(struct wwan_port *port)
>> +{
>> +	WARN_ON(1);	/* This handler cannot be called */
>> +}
>
>Please don't use the inline keyword in .c files unless there is a
>demonstrable - usually performance - reason to do so. Rather, let the
>compiler inline code as it sees fit.
>
>Using the inline keyword in .h is of course fine.
>
I think this shall be a mistake.
For a GNSS device, these 2 API shall not be called frequently.
So there is no necessary to add "inline" to improve performance.
How do you think, Sergey?

>> +#endif
>> +
>
>...