Re: [PATCH v6 2/3] of: factor arguments passed to of_map_id() into a struct

[Dmitry Baryshkov]

On Wed, 21 Jan 2026 at 08:38, Vijayanand Jitta
<vijayanand.jitta@xxxxxxxxxxxxxxxx> wrote:
>
>
>
> On 1/21/2026 11:30 AM, Dmitry Baryshkov wrote:
> > On Wed, 21 Jan 2026 at 07:54, Vijayanand Jitta
> > <vijayanand.jitta@xxxxxxxxxxxxxxxx> wrote:
> >>
> >> From: Charan Teja Kalla <charan.kalla@xxxxxxxxxxxxxxxx>
> >>
> >> Introduce a new struct type where the optional arguments passed to
> >> of_map_id() are Currently embedded as of_phandle_args struct.
> >> Subsequent patches add additional arguments to the struct that the
> >> caller expects to be filled of_map_id().
> >
> > Which additional arguments? I don't see anything being added in 3/3 of
> > this series.
> >
> > Can we use of_phandle_args and switch to of_map_id_args when it's
> > actually required.
> >
>
> As mentioned in the cover letter, this change prepares the interface for a
> follow-up series adding multi-map support, which we will be sending out
> shortly and which extends these arguments. Keeping this in place avoids a
> subsequent rework and keeps the overall transition incremental.

Could you please point out patches adding more args.

>
>
> Thanks,
> Vijay
>
> >>
> >> Suggested-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> >> Signed-off-by: Charan Teja Kalla <charan.kalla@xxxxxxxxxxxxxxxx>
> >> Signed-off-by: Vijayanand Jitta <vijayanand.jitta@xxxxxxxxxxxxxxxx>
> >> ---
> >>  drivers/cdx/cdx_msi.c                 |  2 +-
> >>  drivers/iommu/of_iommu.c              | 12 ++++++---
> >>  drivers/of/base.c                     | 37 +++++++++++++--------------
> >>  drivers/pci/controller/dwc/pci-imx6.c | 10 ++++++--
> >>  drivers/pci/controller/pcie-apple.c   |  4 ++-
> >>  drivers/xen/grant-dma-ops.c           | 20 +++++++++------
> >>  include/linux/of.h                    | 32 ++++++++++++++++++-----
> >>  7 files changed, 75 insertions(+), 42 deletions(-)
> >>
> >
> >
>


-- 
With best wishes
Dmitry