Re: [PATCH v4 4/5] PCI: dwc: Rework the error print of dw_pcie_wait_for_link()

[Niklas Cassel]

On Tue, Jan 20, 2026 at 11:17:43PM +0530, Manivannan Sadhasivam via B4 Relay wrote:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxxxxxxxx>
> 
> If the link fails to come up even after detecting the device on the bus
> i.e., if the LTSSM is not in Detect.Quiet and Detect.Active states, then
> dw_pcie_wait_for_link() should log it as an error.

Nit: maybe you should mention Poll.Active and Poll.Compliance here too?


> 
> So promote dev_info() to dev_err(), reword the error log to make it clear
> and also print the LTSSM state to aid debugging.
> 
> Tested-by: Richard Zhu <hongxing.zhu@xxxxxxx>
> Tested-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> Reviewed-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxxxxxxxx>
> ---

Regardless:
Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx>