Re: [PATCH v7 1/4] i2c: tegra: Introduce tegra_i2c_variant to identify DVC and VI

[Kartik Rajput]

Hi Andi,

Thanks for reviewing the patch!

On 21/01/26 14:30, Andi Shyti wrote:
> External email: Use caution opening links or attachments
>
>
> Hi Kartik,
>
> ...
>
> > @@ -323,12 +334,13 @@ struct tegra_i2c_dev {
> >        bool atomic_mode;
> >        bool dma_mode;
> >        bool msg_read;
> > -     bool is_dvc;
> > -     bool is_vi;
> > +     enum tegra_i2c_variant variant;
>
> why do we need this extra step in this patch and we don't add
> "variant" directly in tegra_i2c_dev->hw?
Since we are also introducing match data for DVC and VI variant, I
decided to split this into two patches.

If you prefer, I can squash following into a single patch:
 * "i2c: tegra: Introduce tegra_i2c_variant to identify DVC and VI"
 * "i2c: tegra: Move variant to tegra_i2c_hw_feature"

Thanks,
Kartik