Re: [PATCH v4] pwm: tiehrpwm: Enable pwmchip's parent device before setting configuration
From: Gokul Praveen
Date: Wed Jan 21 2026 - 06:13:56 EST
Hello Uwe,
On 21/01/26 15:48, Uwe Kleine-König wrote:
Hello Gokul,
On Wed, Jan 21, 2026 at 11:41:34AM +0530, Gokul Praveen wrote:
The period and duty cycle configurations on J7200 and J784S4 SoCs
does not get reflected after setting them using sysfs nodes.
This is because at the end of ehrpwm_pwm_config function,
the put_sync function is called which resets the hardware.
Hold the PWM controller out of low-power mode during .apply() to
make sure it accepts the writes to its registers.
This renders the calls to pm_runtime_get_sync() and
pm_runtime_put_sync() in ehrpwm_pwm_config() into no-ops, so
these can be dropped.
Fixes: 5f027d9b83db("pwm: tiehrpwm: Implement .apply() callback")
Signed-off-by: Gokul Praveen <g-praveen@xxxxxx>
I applied this patch to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
and will send it during the next merge window. The problem is old
(v5.18-rc1~54^2~29 from 2021) and it's late in the development cycle, so
I won't bother Linus with it for 6.19.
Thank you for your continued support on this issue as well as for accepting the patch.
Best Regards
Gokul Praveen
Best regards
Uwe