Re: [PATCH] gpio: shared: propagate configuration to pinctrl

[Bartosz Golaszewski]

On Wed, Jan 21, 2026 at 1:10 PM Linus Walleij <linusw@xxxxxxxxxx> wrote:
>
> On Tue, Jan 20, 2026 at 4:49 PM Bartosz Golaszewski
> <bartosz.golaszewski@xxxxxxxxxxxxxxxx> wrote:
>
> > Just toggling the descriptor's "requested" flag is not enough. We need
> > to properly request it in order to potentially propagate any
> > configuration to pinctrl via the .request() callback.
> >
> > We must not take the reference to the device at this point (the device
> > is not ready but we're also requesting the device's own descriptor) so
> > make the _commit() variants of request and free functions available to
> > GPIO core in order to use them instead of their regular counterparts.
> >
> > This fixes an audio issue reported on one of the Qualcomm platforms.
> >
> > Fixes: a060b8c511ab ("gpiolib: implement low-level, shared GPIO support")
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
>
> I don't quite understand all semantics but I guess it works
> like this:  gpiod_request_commit() is only called once, during
> proxy device creation.
>
> If I understand it correct:
> Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>
>

Yes, we effectively hog the pin and allow access to it only though the proxy.

Bartosz