Re: [PATCH v2 1/2] rtl8723bs: Refactor continual_io_error check

[Dan Carpenter]

On Tue, Jan 20, 2026 at 10:11:25PM +0800, 2023060904@xxxxxxxxxx wrote:
> From: Changjun Zheng <guagua210311@xxxxxx>
> 
> Refactor the error count check logic to follow kernel 'single responsibility' principle:
> 1. Move the increment logic (atomic_inc) from rtw_inc_and_chk_continual_io_error() to its callers in sdio_ops_linux.c (line 226/302)
> 2. Keep only the check logic in rtw_inc_and_chk_continual_io_error() (use atomic_read to get current count)
> 
> This change addresses Greg KH's feedback to move increment to callers, while keeping atomic operations to ensure no compilation/run-time errors.
> 

There are a lot of style issues in this patch.  I also still don't
really understand why we are doing this.  Was Greg's email this one?

https://lore.kernel.org/all/2025121757-crowbar-junkman-a96a@gregkh/

I'm guessing that Greg wants you to change this to refcount_t.

regards,
dan carpenter