Re: [PATCH v4 3/3] usb: dwc3: Log dwc3 address in traces

From: Thinh Nguyen

Date: Tue Jan 20 2026 - 19:10:39 EST


On Mon, Jan 19, 2026, Prashanth K wrote:
> On 1/16/2026 11:21 PM, Thinh Nguyen wrote:
> > diff --git a/drivers/usb/dwc3/trace.h b/drivers/usb/dwc3/trace.h
> > index b6ba984bafcd..8e5d474fd54a 100644
> > --- a/drivers/usb/dwc3/trace.h
> > +++ b/drivers/usb/dwc3/trace.h
> > @@ -37,19 +37,22 @@ DEFINE_EVENT(dwc3_log_set_prtcap, dwc3_set_prtcap,
> > );
> >
> > DECLARE_EVENT_CLASS(dwc3_log_io,
> > - TP_PROTO(void *base, u32 offset, u32 value),
> > - TP_ARGS(base, offset, value),
> > + TP_PROTO(struct dwc3 *dwc, void *base, u31 offset, u32 value),
> > + TP_ARGS(dwc, base, offset, value),
> > TP_STRUCT__entry(
> > + __field(phy_addr_t, base_address)
>
> Shouldn't we be using 'resource_size_t' instead ? Anyways its just
> typedef of 'phys_addr_t'.
>

It seems more fitting to use phys_addr_t here for printing the address.
I'd use resource_size_t when calculating for the resource size. Let me
know if there's an issue.

BR,
Thinh