Re: [PATCH] power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer
From: Val Packett
Date: Tue Jan 20 2026 - 18:14:29 EST
On 1/19/26 3:38 AM, Dmitry Baryshkov wrote:
On Sat, Jan 17, 2026 at 06:09:24PM -0300, Val Packett wrote:
On the Dell Latitude 7455, the firmware uses "LiP" with a lowercase 'i'Why do you have extra brackets around the second strncmp?
for the battery chemistry type, but only all-uppercase "LIP" was being
recognized. Add the CamelCase variant to the check to fix the "Unknown
battery technology" warning.
Fixes: 202ac22b8e2e ("power: supply: qcom_battmgr: Add lithium-polymer entry")
Signed-off-by: Val Packett <val@xxxxxxxxxxxx>
---
drivers/power/supply/qcom_battmgr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c
index c8028606bba0..80e701c66434 100644
--- a/drivers/power/supply/qcom_battmgr.c
+++ b/drivers/power/supply/qcom_battmgr.c
@@ -1240,7 +1240,8 @@ static unsigned int qcom_battmgr_sc8280xp_parse_technology(const char *chemistry
if ((!strncmp(chemistry, "LIO", BATTMGR_CHEMISTRY_LEN)) ||
(!strncmp(chemistry, "OOI", BATTMGR_CHEMISTRY_LEN)))
return POWER_SUPPLY_TECHNOLOGY_LION;
- if (!strncmp(chemistry, "LIP", BATTMGR_CHEMISTRY_LEN))
+ if (!strncmp(chemistry, "LIP", BATTMGR_CHEMISTRY_LEN) ||
+ (!strncmp(chemistry, "LiP", BATTMGR_CHEMISTRY_LEN)))
Copy-pasted from the line above (the "OOI" one) :) Didn't see that the first one in this expression doesn't have them.
Feel free to edit this when applying
~val