Re: [PATCH] drm/nouveau/disp: Set drm_mode_config_funcs.atomic_(check|commit)

[Dave Airlie]

On Thu, 22 Jan 2026 at 05:13, Lyude Paul <lyude@xxxxxxxxxx> wrote:
>
> Apparently we never actually filled these in, despite the fact that we do
> in fact technically support atomic modesetting.
>
> Since not having these filled in causes us to potentially forget to disable
> fbdev and friends during suspend/resume, let's fix it.
>
> Signed-off-by: Lyude Paul <lyude@xxxxxxxxxx>

Reviewed-by: Dave Airlie <airlied@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> ---
>  drivers/gpu/drm/nouveau/nouveau_display.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
> index 00515623a2cc7..829c2b573971c 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_display.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_display.c
> @@ -352,6 +352,8 @@ nouveau_user_framebuffer_create(struct drm_device *dev,
>
>  static const struct drm_mode_config_funcs nouveau_mode_config_funcs = {
>         .fb_create = nouveau_user_framebuffer_create,
> +       .atomic_commit = drm_atomic_helper_commit,
> +       .atomic_check = drm_atomic_helper_check,
>  };
>
>
>
> base-commit: 68b271a3a94cfd6c7695a96b6398b52feb89e2c2
> --
> 2.52.0
>