Re: [PATCH bpf-next v6 4/4] selftests/bpf: Add tests for signature verification kfuncs

[Daniel Hodges]

> > Signed-off-by: Daniel Hodges <git@xxxxxxxxxxxxxxxx>
> > ---
> >  MAINTAINERS                                   |   2 +
> >  .../selftests/bpf/prog_tests/sig_verify.c     | 163 ++++++++++
> >  .../selftests/bpf/progs/crypto_common.h       |   6 +
> >  .../testing/selftests/bpf/progs/sig_verify.c  | 286 ++++++++++++++++++
> >  4 files changed, 457 insertions(+)
> >  create mode 100644 tools/testing/selftests/bpf/prog_tests/sig_verify.c
> >  create mode 100644 tools/testing/selftests/bpf/progs/sig_verify.c
> 
> It's a v6 already, but your new selftests are still failing in CI.
> 
> Error: #385 sig_verify
> Error: #385/1 sig_verify/verify_valid_signature
> Error: #385/3 sig_verify/size_queries
> Error: #385/6 sig_verify/zero_len_msg
> Error: #385/7 sig_verify/zero_len_sig
> 
> Please make sure CI is green before submitting v7.
> No one is reviewing the patches when they don't pass their own tests.

Noted, sorry about that. I think my local vm has some different config:

vng -- ./tools/testing/selftests/bpf/test_progs -t sig_verify
WARNING! Selftests relying on bpf_testmod.ko will be skipped.
Can't find bpf_testmod.ko kernel module: -2
#385/1   sig_verify/verify_valid_signature:OK
#385/2   sig_verify/verify_invalid_signature:OK
#385/3   sig_verify/size_queries:OK
#385/4   sig_verify/ecdsa_on_hash_ctx:OK
#385/5   sig_verify/ecdsa_keysize_on_hash_ctx:OK
#385/6   sig_verify/zero_len_msg:OK
#385/7   sig_verify/zero_len_sig:OK
#385     sig_verify:OK
Summary: 1/7 PASSED, 0 SKIPPED, 0 FAILED

I'll figure it out properly, thanks for the direction!