Re: [PATCH v4 0/3] platform/x86: asus-wmi: move keyboard control firmware attributes

[Denis Benato]

On 1/3/26 00:43, Denis Benato wrote:
> Hi all,
>
> I was recently reading through the asusctl issue tracker and I found
> out that some users have been having troubles with the keyboard RGB control
> that was working before since the creation of asus-armoury and subequent
> deprecation of old sysfs attributes.
>
> This patch series aims to re-introduce those attributes in asus-armoury
> so that userspace tools can still control keyboard RGB lighting
> without having to rely on deprecated asus-wmi attributes.
>
> In addition to that, since disabling OOBE is essential for controlling
> LEDs on some models and it was incorrectly tied to deprecated attributes,
> this patch series also fixes sending OOBE at probe time.
>
> Link: https://gitlab.com/asus-linux/asusctl/-/issues/619
Hi Ilpo, please disregard everything in this patch series except the OOBE fix:
that fix is important and I see it has been picked up.

It's probably much better not to touch keyboard modes without a rework
of the associated RGB interface: it doesn't make sense to move only the
power state and I already saw there have been reported problems
with TUFs.

The original problem I was trying to solve is better solved another way
via userspace saving the last setting with the interface already provided.

Thanks,
Denis
> Regards,
> Denis
>
> Changelog:
> - v1
>   - Initial submission
> - v2
>   - asus-armoury: drivers should be silent on success
>   - asus-armoury: make better use of __free annotation
> - v3
>   - asus-wmi: use GENMASK for flags
>   - asus-armoury: fix error handling in keyboard attribute creation
>   - asus-armoury: fix logic bug in error path
>   - asus-armoury: use proper defines for keyboard state flags
> - v4
>   - asus-armoury: reorder variable declarations
>   - asus-armoury: add bitfields.h include for BIT and FIELD_PREP
>   - asus-armoury: reorganize armoury_kbd_state() for clarity
>
> Denis Benato (3):
>   platform/x86: asus-wmi: explicitly mark more code with
>     CONFIG_ASUS_WMI_DEPRECATED_ATTRS
>   platform/x86: asus-wmi: fix sending OOBE at probe
>   platform/x86: asus-armoury: add keyboard control firmware attributes
>
>  drivers/platform/x86/asus-armoury.c        | 253 +++++++++++++++++++++
>  drivers/platform/x86/asus-wmi.c            |  13 +-
>  include/linux/platform_data/x86/asus-wmi.h |  18 ++
>  3 files changed, 283 insertions(+), 1 deletion(-)
>