Re: [PATCH v2 1/2] rust: kbuild: extract configs for reuse

[Miguel Ojeda]

On Tue, Jan 20, 2026 at 5:10 PM Tamir Duberstein <tamird@xxxxxxxxxx> wrote:
>
> Introduce `pin_init{,_internal}-{cfgs,flags}` and pass these new cfgs to
> `generate_rust_analyzer.py` to reduce duplicate information.
>
> Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxxx>

Looks good -- my suggestion was to move the two rust-analyzer lines
here (`--cfgs=`) also into the second patch, i.e. here it would just
be about factoring out the flags, and then in the second one you pass
them to `rust-analyzer` and use the information.

Doing it here doesn't hurt, since it will be unused on the script
side, so it is also fine, but I thought it would be more
understandable the other way around.

Anyway, I could perhaps take this one with or without the two lines,
and then next cycle you can apply to rust-analyzer the other one.

Thanks!

Cheers,
Miguel